Skip to content

Changed Earth radius to reflect the constant used by MongoDB #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

rps
Copy link

@rps rps commented Dec 12, 2013

MongoDB sets a constant defining the Earth's radius in km as 6378.1. Documentation should reflect this to ensure that users are consistent in their conversion from km to rad.

@rps
Copy link
Author

rps commented Dec 12, 2013

Because MongoDB converts radians to meters using the equatorial radius of the Earth, rather than the average radius of the Earth, documentation should recommend using this number to ensure correct conversions. Currently, documentation recommends using the average radius, which will result in a slightly inaccurate conversion.

@kangas
Copy link
Contributor

kangas commented Dec 17, 2013

Docs team - please hold pending a review of mongodb/mongo#588 (SERVER-12128). @rps discovered that we have been inconsistent in our use of this constant, and we need to sort out which value we're committing to across the board.

@mpaik
Copy link
Contributor

mpaik commented Mar 17, 2015

Bulk closing stale pull requests.

@mpaik mpaik closed this Mar 17, 2015
@rps
Copy link
Author

rps commented Mar 17, 2015

The net effect of having documentation inconsistent with the constants used by Mongo is that end users will conduct inaccurate conversions from kilometers to radians. For geospatial applications reliant on Mongo, this results in inaccurate and incomplete proximity search. While I understand that changing the constant used by Mongo breaks existing indexes, I still don't understand why the documentation does not reflect the variable used.

@mpaik
Copy link
Contributor

mpaik commented Mar 18, 2015

Merged.

@mpaik mpaik closed this Mar 18, 2015
mongo-cr-bot pushed a commit that referenced this pull request Jul 15, 2022
* DOCSP-22373 adding new push example

* DOCSP-22373 adding new push example

* DOCSP-22373 adding new push example

* DOCSP-22373 adding new push example

* DOCSP-22373 adding new push example

* DOCSP-22373 minor edits

* DOCSP-22373 minor word change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants