Skip to content

DOCS-4844: Document need to limit WiredTiger cache #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

i80and
Copy link
Contributor

@i80and i80and commented Mar 27, 2015

No description provided.

@kay-kim
Copy link
Contributor

kay-kim commented Mar 27, 2015

you should rebase your branch before doing the pull request. This patch reverses changes that were made in a patch while you were in code review. So generally, the sequence should be:

  1. Modify files
  2. git pull --rebase
  3. Code review
    a. edits per review comments
    b. resubmit code review
    c. repeat steps as necessary until LGTM
  4. git pull --rebase
  5. then push

@i80and
Copy link
Contributor Author

i80and commented Mar 30, 2015

I rebase compulsively; this is just a situation where I screwed up the merge and picked the wrong side.

Sorry about that!

@i80and i80and force-pushed the DOCS-4844 branch 2 times, most recently from 5ac96fd to b622beb Compare March 30, 2015 18:46
@@ -0,0 +1,12 @@
The default value for this setting is optimized for a single :program:`mongod`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would change "this setting" to the specific setting (a little redundant, but since it is an include file, it's kind of necessary).

Is it optimized? That claim is one of those that needs to be verified. If true, then fine. If not, update word choice.

@kay-kim
Copy link
Contributor

kay-kim commented Mar 31, 2015

merged.

@kay-kim kay-kim closed this Mar 31, 2015
mongo-cr-bot pushed a commit that referenced this pull request Dec 9, 2022
…2249)

* DOCSP-26700 Removes EOL version references from Replication  (#2194)

* Fixes build error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants