-
Notifications
You must be signed in to change notification settings - Fork 1.7k
DOCS-7678 recommend kernel.pid_max of 64000 #2603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @devkev -- I just need to get rid of one of the two 64000 values, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhhh, no?
The idea is that if pid_max is only 32768, then setting the nprocs ulimit to 64000 won't have the desired effect. To put it another way, the user expectation is that after setting nprocs to 64000, they can have up to 64000 processes/threads on the system. But this is only possible if pid_max is also >= nprocs, i.e. is >= 64000. If it is less --- like the 32768 that we recommend here --- then the number of possible processes/threads will cap out less than 64000, which is confusing.
Therefore, we should ensure that we recommend setting pid_max to at least our recommended value for the nprocs ulimit. Since we recommend nprocs be 64000, we should also recommend pid_max of 64000 --- which is what this patch does.
This is all assuming that the three values listed here correspond to file-max, pid_max and threads-max, respectively. Feel free to rework things further to make that clearer, if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see now. I didn't realize that the three values listed corresponded to the file-max, pid_max and threads-max : (
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a vote for "it should be clearer" :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed : )