Skip to content

DOCS-8981: Document maxLogSizeKB parameter #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2017
Merged

DOCS-8981: Document maxLogSizeKB parameter #3157

merged 2 commits into from
Dec 15, 2017

Conversation

kallimachos
Copy link
Contributor

@kallimachos kallimachos commented Dec 8, 2017

Also fix two minor typos.


This change is Reviewable

@devkev
Copy link
Contributor

devkev commented Dec 11, 2017

This is good, thanks for that. My only suggestion is to add a warning that large values of this parameter can adversely affect system performance.

As an example of the potential impact (this detail doesn't necessarily have to end up in the docs), suppose a mongod/mongos is attempting to log 100 "long" (over 10MB) lines per second (massive queries, say). With the default maxLogSizeKB of 10, this is a logging rate of about 1MB/s. However, with a value of 10000, it's a logging rate of about 1GB/s. This is extra bad because log lines are written synchronously - which is why I'm concerned about it affecting the perf of actual db ops.


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@kallimachos
Copy link
Contributor Author

@devkev If you would be so kind as to ignore the extraneous commits from rebasing and just have a look at source/reference/parameters.txt for the added warning, I'd be much obliged.

Thanks!

@devkev
Copy link
Contributor

devkev commented Dec 11, 2017

:lgtm:


Reviewed 1 of 1 files at r3.
Review status: 2 of 5 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@kay-kim
Copy link
Contributor

kay-kim commented Dec 14, 2017

@kallimachos -- could you do a rebase so that we don't have the other commits in this pull request?

@kallimachos
Copy link
Contributor Author

@kay-kim Should be better now. Thanks!

@kay-kim kay-kim merged commit d0dbf79 into mongodb:master Dec 15, 2017
@kallimachos kallimachos deleted the DOCS-8981 branch December 18, 2017 03:28
mongo-cr-bot pushed a commit that referenced this pull request May 17, 2023
* DOCSP-15287 remove multiple key string references

* DOCSP-15287 remove multiple key string tab

* DOCSP-15287 remove multiple key string tab

* DOCSP-15287 nit fix

* DOCSP-15287 internal feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants