Skip to content

(DOCS-11711): Updated downgrade shutdown requirement. #3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2018

Conversation

atsansone
Copy link
Contributor

@MongoCaleb : There are a few line wrap issues, but the big thing is the note that I added:

Staging build is still ongoing. Stage may not reflect code.

Copy link
Contributor

@MongoCaleb MongoCaleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % 2 nits

@atsansone atsansone changed the title (DOCS-11217): Updated downgrade shutdown requirement. (DOCS-11711): Updated downgrade shutdown requirement. Jun 11, 2018
@atsansone
Copy link
Contributor Author

@mbrinsmead : Review to you. Thanks!

@kevarh
Copy link

kevarh commented Jun 12, 2018

errors result

I'd go with "errors may result". If it shuts down in under five minutes, you're OK.

One note that isn't important to include here is... Forcibly terminating mongod can cause .count() and db.stats() to be wrong as well as lengthen startup time on next boot (we have to run WT Recovery).

I can't see the entire context, do we call out db.shutDownServer() as the preferred choice in <terminate-mongod-processes>?

Other than that LGTM.

@atsansone
Copy link
Contributor Author

@kay-kim : RFM for master and v3.6.

@mbrinsmead
Copy link

Reviewed changes mades for DOCS-11711. LGTM -- this should meet out need.

@kay-kim kay-kim merged commit 482155c into mongodb:master Jun 13, 2018
mongo-cr-bot pushed a commit that referenced this pull request Jun 21, 2023
* DOCSP-29121 OIDC Authentication (#3302)

* DOCSP-29121 draft redo

* DOCSP-29121 rework details

* DOCSP-29121 fix links

* DOCSP-29121 internal feedback

* DOCSP-29121
external updates

* DOCSP-29130 release notes (#3375)

* DOCSP-29125 oidcIdentityProviders server parameter (#3319)

* DOCSP-29125 configure mongodb for oidc

* DOCSP-29125 server parameter

* DOCSP-29125 fix table

* DOCSP-29125 fix table

* DOCSP-29125 fix table

* DOCSP-29125 fix table

* DOCSP-29125 fix table

* DOCSP-29125 internal feedback

* DOCSP-29125 typo fixes

* DOCSP-29125 typo fix

* DOCSP-29125 typo fix

* DOCSP-29125 trying to get staging

* DOCSP-29125 remove old fields

* DOCSP-29125 external feedback

* DOCSP-29125 external

* DOCSP-29125 external

* DOCSP-29125 external

* DOCSP-29125 remove clientSecret

* DOCSP-29125 fix ref

* DOCSP-29125 nit fix

* DOCSP-29123 OIDC task page (#3335)

* DOCSP-29123 task page

* DOCSP-29123 fix second step

* DOCSP-29123 fix second step

* DOCSP-29123 fix second step

* DOCSP-29123 fixing new step

* DOCSP-29123 update second step

* DOCSP-29123 add link

* DOCSP-29123 update refs

* DOCSP-29123 update step

* DOCSP-29123 update

* DOCSP-29123 internal updates

* DOCSP-29123 fixed ref

* DOCSP-29123 add mongosh comment

* DOCSP-29123 add tabs

* DOCSP-29123 syntax fixes

* DOCSP-29123 nit fix

* DOCSP-29123
add toc tree

* DOCSP-29123
add toc tree

* DOCSP-29123 update ref

* DOCSP-29123 updates

* DOCSP-29124 OIDC in Authentication Page (#3391)

* DOCSP-29124 create include and add oidc to auth

* DOCSP-29124 create include and add oidc to auth

* DOCSP-29124 fix ref

* DOCSP-29124 fix ref

* DOCSP-29124 internal feedback

* DOCSP-29124 internal feedback

* oidc-docs update link name

* oidc-docs update ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants