DOCS-11940: uri option compressors and zlibcompressionlevel #3519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kay-kim
commented
Dec 11, 2018
| @@ -323,12 +323,74 @@ Connection Options | |||
| timeout, though different drivers might vary. See the | |||
| :ecosystem:`driver </drivers>` documentation. | |||
|
|
|||
| * - .. urioption:: compressors | |||
There was a problem hiding this comment.
kay-kim
commented
Dec 11, 2018
| messages between the parties are uncompressed. | ||
|
|
||
|
|
||
| * - .. urioption:: zlibCompressionLevel |
There was a problem hiding this comment.
saghm
approved these changes
Dec 11, 2018
| If you specify multiple compressors, then the order in which you list | ||
| the compressors matter as well as the communication initiator. For | ||
| example, if the client specifies the following network | ||
| compressors ``zlib,snappy`` and the :binary:`~bin.mongod` specifies |
There was a problem hiding this comment.
From looking at the rendered view, adding quotes to the compressors list examples (e.g. ``"zlib,snappy"``) might make them more readable in the browser, as it's a little tricky to notice that the comma before "messages" is not part of the compressors list. This is totally outside my expertise, though, so feel free to ignore this if you disagree!
There was a problem hiding this comment.
Thank you! Will definitely add the quotes 👍
mongo-cr-bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
* DOCSP-31125 add curl to package import * Force build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@saghm - Could you review the addition of uri options compressors and zlibCompressionLevel to the uri page in the docs?