Skip to content

DOCS-12492 #4032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

DOCS-12492 #4032

wants to merge 5 commits into from

Conversation

niccottrell
Copy link
Contributor

Here's my first go at a change for this DOCS ticket. I'm not sure how to test it.

~~~~~~~~~~~~~~~~~~~~~~~~~~

It is possible to tune the performance impact of :dbcommand:`cleanupOrphaned`
with two server parameters `rangeDeleterBatchSize</reference/parameters/#param.rangeDeleterBatchSize>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can actually just go :parameter:`rangeDeleterBatchSize` and :parameter:`rangeDeleterBatchDelayMS`

As @devkev mentioned in the DOCS-12492, since these settings would also affect chunk migration, we probably should mention this fact -- in case people really just want to set them temporarily for the command - but want whatever for the chunk migration.

Also, probably the content should go with the Performance section --
https://github.com/mongodb/docs/pull/4032/files#diff-01c6bc4c93806419712b7070b0efe7e5L113

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh -- and does git pull --rebase not work? We tend to keep our commits 1 per fix.

@kay-kim
Copy link
Contributor

kay-kim commented Apr 1, 2020

Thanks Nic. What I'll probably do to avoid popping in the other extraneous commits is to

  1. pull down your changes,
  2. cherry-pick the last 2 commits and squash, and
  3. tweak the note to .. note:: so that it becomes a little bit more prominent (just as a precaution in case people skip over since this would affect regular chunk migration)
  4. merge
  5. close this pull request

This will probably be later this evening. Am in the middle of writing up some map-reduce -> agg counterpart examples and want to finish that up first.

Kay

@kay-kim
Copy link
Contributor

kay-kim commented Apr 2, 2020

Merged: 48b4814

Then tweaked:
15902b2

Closing this pull.

@kay-kim kay-kim closed this Apr 2, 2020
mongo-cr-bot pushed a commit that referenced this pull request Jul 18, 2023
…3485) (#4032)

* DOCSP-24205 updated sales example to be more intuitive and readable

* fixed sort example

* made internal review changes

* more internal review changes

* formatting issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants