Skip to content

minor copy edits to the v8 javascript lock statements #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/applications/map-reduce.txt
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ These various tasks take the following locks:
``merge``, ``replace``, ``reduce``) take a write lock.

.. versionchanged:: 2.4
The V8 JavaScript engine, which became the default in 2.4 allows
The V8 JavaScript engine, which became the default in 2.4, allows
multiple JavaScript operations to execute at the same time. Prior to
2.4, JavaScript code (i.e. ``map``, ``reduce``, ``finalize``
functions) executed in a single thread.
Expand Down
2 changes: 1 addition & 1 deletion source/reference/command/eval.txt
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ eval
- .. include:: /includes/fact-eval-authentication.rst

.. versionchanged:: 2.4
The V8 JavaScript engine, which became the default in 2.4 allows
The V8 JavaScript engine, which became the default in 2.4, allows
multiple JavaScript operations to execute at the same
time. Prior to 2.4, :dbcommand:`eval` executed in a single
thread.
Expand Down
11 changes: 7 additions & 4 deletions source/reference/command/group.txt
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,16 @@ group
groupings, use :dbcommand:`mapReduce`. Previous versions had a
limit of 10,000 elements.

.. putting the blank line between the version changed directive
since the directive cannot seem to handle the include or the
list at all
.. versionchanged:: 2.4

- .. include:: /includes/fact-group-map-reduce-where-limitations-in-24.rst
- .. include:: /includes/fact-group-map-reduce-where-limitations-in-24.rst

- Prior to 2.4, the :dbcommand:`group` command took the
:program:`mongod` instance's JavaScript
lock, which blocked all other JavaScript execution.
- Prior to 2.4, the :dbcommand:`group` command took the
:program:`mongod` instance's JavaScript lock, which blocked
all other JavaScript execution.

For the shell, MongoDB provides a wrapper method
:method:`db.collection.group()`; however, the
Expand Down
5 changes: 3 additions & 2 deletions source/reference/method/db.collection.group.txt
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,9 @@ db.collection.group()

- .. include:: /includes/fact-group-map-reduce-where-limitations-in-24.rst

- Prior to 2.4, the :method:`db.collection.group()` method took a
JavaScript lock.
- Prior to 2.4, the :method:`db.collection.group()` method took
the :program:`mongod` instance's JavaScript lock, which blocked
all other JavaScript execution.

Consider the following examples of the :method:`db.collection.group()` method:

Expand Down
7 changes: 4 additions & 3 deletions source/reference/method/db.eval.txt
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,10 @@ db.eval()
- .. include:: /includes/fact-eval-authentication.rst

.. versionchanged:: 2.4
The V8 JavaScript engine added in 2.4 allows multiple JavaScript
operations to run at the same time. Prior to 2.4,
:method:`db.eval()` would take a JavaScript lock.
The V8 JavaScript engine, which became the default in 2.4, allows
multiple JavaScript operations to execute at the same
time. Prior to 2.4, :method:`db.eval()` executed in a single
thread.

.. seealso::

Expand Down