feat: Adds AdvancedConfiguration attribute #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
reviewed
Apr 3, 2025
| } | ||
|
|
||
| // AdvancedConfiguration group of settings that configures a subset of the advanced configuration details. | ||
| type AdvancedConfiguration struct { |
There was a problem hiding this comment.
As it's in the global SDK package, should we add "cluster" to the name, like AdvancedConfigurationCluster? or it's clear that AdvancedConfiguration refers only to clusters?
There was a problem hiding this comment.
It resembles the attribute name in the API, so I think this should be okay as it is
lantoli
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds AdvancedConfiguration attribute support in Cluster APIs.
Ref: https://www.mongodb.com/docs/atlas/reference/api-resources-spec/v2/#tag/Clusters/operation/createCluster
Link to any related issue(s): CLOUDP-296222
Type of change:
Required Checklist:
make fmtand formatted my codeFurther comments