refactor: change parameter name for clarity and use chai asserts for readability

Author: Grace Chong

src/error.ts

@@ -1,7 +1,7 @@
 /** @public */
 export class BSONError extends Error {
-  constructor(m: string) {
-    super(m);
+  constructor(message: string) {
+    super(message);
     Object.setPrototypeOf(this, BSONError.prototype);
   }
 
@@ -12,8 +12,8 @@ export class BSONError extends Error {
 
 /** @public */
 export class BSONTypeError extends TypeError {
-  constructor(m: string) {
-    super(m);
+  constructor(message: string) {
+    super(message);
     Object.setPrototypeOf(this, BSONTypeError.prototype);
   }
 

test/node/error_test.js

@@ -9,8 +9,10 @@ describe('BSON error tests', function () {
     const bsonTypeErr = new BSONTypeError();
     const bsonErr = new BSONError();
 
-    expect(bsonTypeErr instanceof BSONTypeError).to.be.true;
-    expect(bsonErr instanceof BSONError).to.be.true;
+    expect(bsonTypeErr).to.be.instanceOf(BSONTypeError);
+    expect(bsonTypeErr).to.be.instanceOf(TypeError);
+    expect(bsonErr).to.be.instanceOf(BSONError);
+    expect(bsonErr).to.be.instanceOf(Error);
   });
 
   it('should correctly get correct names for BSONTypeError and BSONError', function () {