refactor: remove assertion override and add tests to check for correct error message and names

Author: Grace Chong

test/node/error_test.js

@@ -0,0 +1,25 @@
+'use strict';
+
+const BSON = require('../register-bson');
+const BSONTypeError = BSON.BSONTypeError;
+const BSONError = BSON.BSONError;
+
+describe('BSON error tests', function () {
+  it('should correctly validate instanceof checks for BSONTypeError and BSONError', function () {
+    const bsonTypeErr = new BSONTypeError();
+    const bsonErr = new BSONError();
+
+    expect(bsonTypeErr instanceof BSONTypeError).to.be.true;
+    expect(bsonErr instanceof BSONError).to.be.true;
+  });
+
+  it('should correctly get correct names for BSONTypeError and BSONError', function () {
+    const bsonTypeErr = new BSONTypeError('This is a BSONTypeError message');
+    const bsonErr = new BSONError('This is a BSONError message');
+
+    expect(bsonTypeErr.name).equals('BSONTypeError');
+    expect(bsonTypeErr.message).equals('This is a BSONTypeError message');
+    expect(bsonErr.name).equals('BSONError');
+    expect(bsonErr.message).equals('This is a BSONError message');
+  });
+});

test/register-bson.js

@@ -14,25 +14,4 @@ require('object.entries/auto');
 const BSON = require('../lib/bson');
 const { ensureBuffer } = require('../lib/ensure_buffer');
 BSON.ensureBuffer = ensureBuffer;
-
-const { Assertion, util } = require('chai');
-Assertion.overwriteMethod('throw', function (original) {
-  return function assertThrow(...args) {
-    if (args.length === 0 || args.includes(BSON.BSONError) || args.includes(BSON.BSONTypeError)) {
-      // By default, lets check for BSONError or BSONTypeError
-      // Since we compile to es5 instanceof is broken???
-      const assertion = original.apply(this, args);
-      const object = util.flag(assertion, 'object');
-      return this.assert(
-        object && /BSONError|BSONTypeError/.test(object.stack),
-        'expected #{this} to be a BSONError or a BSONTypeError but got #{act}',
-        'expected #{this} to not be a BSONError nor a BSONTypeError but got #{act}',
-        (object && object.stack) || '<error undefined>'
-      );
-    } else {
-      return original.apply(this, args);
-    }
-  };
-});
-
 module.exports = BSON;