Skip to content

test(NODE-3447): prose tests for serialization of BSON with embedded null bytes in strings #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 20, 2021
Merged

test(NODE-3447): prose tests for serialization of BSON with embedded null bytes in strings #462

merged 6 commits into from
Sep 20, 2021

Conversation

nbbeeken
Copy link
Contributor

Left out the prose tests by accident in the last PR, here they are!

@nbbeeken nbbeeken requested a review from dariakp September 17, 2021 22:02
dariakp
dariakp requested changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look fine, minus the minor comment below, and the clarifications we discussed earlier

@nbbeeken nbbeeken requested a review from dariakp September 20, 2021 18:55
@dariakp dariakp merged commit cc5d04d into master Sep 20, 2021
@dariakp dariakp deleted the NODE-3447/bson-with-null branch September 20, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @dariakp