Skip to content

chore: update nvm environment setup #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

chore: update nvm environment setup #487

merged 1 commit into from
Feb 11, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Feb 10, 2022 •
edited by dariakp
Loading

Description

What is changing?

Update setup scripts, aligning with our other repos

What is the motivation for this change?

Buggy behavior on old systems

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • [N/A] Changes are covered by tests
  • [N/A] New TODOs have a related JIRA ticket

@nbbeeken nbbeeken mentioned this pull request Feb 10, 2022
Merged
5 tasks
@dariakp dariakp marked this pull request as ready for review February 11, 2022 15:56
@dariakp dariakp merged commit 35bb2a2 into master Feb 11, 2022
@dariakp dariakp deleted the chore/nvm branch February 11, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@dariakp dariakp dariakp approved these changes

@baileympearson baileympearson Awaiting requested review from baileympearson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbbeeken @durran @dariakp