chore(NODE-4376): add typescript to eslint rules #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-4321/ts-es-lint
branch
from
0c5fa90 to
5e70517
Compare
baileympearson
added
the
Primary Review
baileympearson
requested changes
Jun 29, 2022
| "typedoc": "^0.21.2", | ||
| "typescript": "^4.0.2", | ||
| "tsd": "^0.21.0", | ||
| "typescript": "^4.7.4", |
There was a problem hiding this comment.
typedoc is intentionally removed here ✅
| @@ -31,22 +30,23 @@ | |||
| "@babel/plugin-external-helpers": "^7.10.4", | |||
| "@babel/preset-env": "^7.11.0", | |||
| "@istanbuljs/nyc-config-typescript": "^1.0.1", | |||
| "@microsoft/api-extractor": "^7.11.2", | |||
| "@microsoft/api-extractor": "^7.28.0", | |||
There was a problem hiding this comment.
confirmed that no new prod dependencies are added ✅
baileympearson
previously approved these changes
Jun 30, 2022
nbbeeken
changed the title
dariakp
requested changes
Jun 30, 2022
There was a problem hiding this comment.
If we actually want to keep all these rules as best practices, can we provide context for the cases where we explicitly disable them as to why it's ok to disable them in that particular case? Otherwise if the instances are out of scope to fix, I would at least tag all those lines with a follow up node ticket
addaleax
reviewed
Jul 1, 2022
src/code.ts
Outdated
| @@ -52,7 +52,7 @@ export class Code { | |||
|
|
|||
| inspect(): string { | |||
| const codeJson = this.toJSON(); | |||
| return `new Code("${codeJson.code}"${ | |||
| return `new Code("${codeJson.code.toString()}"${ | |||
There was a problem hiding this comment.
Do you want to do
Suggested change
| return `new Code("${codeJson.code.toString()}"${ | |
| return `new Code("${String(codeJson.code)}"${ |
here as well, since there is no argument validation in the constructor and this handles null/undefined as well?
nbbeeken
added
Team Review
baileympearson
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
NODE-4376
mongodb/node-mongodb-native#3304
Also updates a number of dependencies.
Is there new documentation needed for these changes?
What is the motivation for this change?
Driver tooling sync
Double check the following
npm run lintscript<type>(NODE-xxxx)<!>: <description>