chore(NODE-4401): enable isolatedModules tsc compiler option #507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
compiling
js-bson
withisolatedModules
set totrue
Is there new documentation needed for these changes?
no, as per https://www.typescriptlang.org/tsconfig#isolatedModules the behaviour of the code does not change
What is the motivation for this change?
I'm working on a feature complete port of
js-bson
for deno. Idea is to "compile" this library automatically for deno, intobson-deno
Current state of
bson-deno
can be reviewed here: https://github.com/thekorn/bson-denoThe "build" script is maintained in this repository: https://github.com/thekorn/deno-build-mongodb-native
The overall goal is to provide an up-to-date, feature complete version of the mongodb-native client library for deno
For tracking purposes I also created a jira ticket: https://jira.mongodb.org/browse/NODE-4401
Double check the following
npm run lint
script<type>(NODE-xxxx)<!>: <description>