feat!(NODE-4461): remove Decimal128 toObject transformer #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
previously approved these changes
Nov 23, 2022
nbbeeken
force-pushed
the
NODE-4461-rm-toObject-d128
branch
from
991fc9d to
572a5f9
Compare
nbbeeken
force-pushed
the
NODE-4461-rm-toObject-d128
branch
from
572a5f9 to
563e539
Compare
dariakp
requested changes
Nov 29, 2022
dariakp
added
the
Primary Review
Co-authored-by: Daria Pardue <[email protected]>
dariakp
added
Team Review
dariakp
approved these changes
Nov 30, 2022
baileympearson
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Remove toObject transformer for d128
What is the motivation for this change?
Difficult maintenance, and unexpected results from serializer when defined (toObject's return type isn't constrained)
Double check the following
npm run lintscript<type>(NODE-xxxx)<!>: <description>