chore(NODE-5277): add definition clean up script #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
commented
May 10, 2023
Comment on lines
+29
to
+30
| const emptyDirectories = Array.from(walk(libPath)) | ||
| .filter(filePath => fs.statSync(filePath).isDirectory() && fs.readdirSync(filePath).length === 0); |
There was a problem hiding this comment.
Unlike the driver, BSON has only the top-level bundles in lib/ so the lib/parser/ and lib/utils/ directories can be cleaned up.
baileympearson
previously approved these changes
May 16, 2023
| @@ -0,0 +1,35 @@ | |||
| #! /usr/bin/env node | |||
There was a problem hiding this comment.
just curious - any reason we're using a cjs module if we're not using top level await?
There was a problem hiding this comment.
A few non binding reasons:
- aligning with the choice made in the driver
- esm and await is slower for scripting tasks like this
- cjs has greater compatibility, it can be a nice-to-have that little scripts like this run fine on node 8 (still a common version on linux package managers) despite the package src having a higher node requirement.
test/node/release.test.ts
Outdated
| let tarFileList; | ||
| before(function () { | ||
| this.timeout(120_000); // npm pack can be slow | ||
| expect(fs.existsSync(packFile)).to.equal(false); |
There was a problem hiding this comment.
Suggested change
| expect(fs.existsSync(packFile)).to.equal(false); | |
| expect(fs.existsSync(packFile), 'expected pack file not to exist, but it does').to.equal(false); |
There was a problem hiding this comment.
I put the file name in the expectation
|
one question, one optional change |
baileympearson
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
What is the motivation for this change?
Clean extraneous files
Double check the following
npm run lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript