Skip to content

ci(NODE-5403): add string deserialization benchmark to ci #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 14, 2023
Merged

ci(NODE-5403): add string deserialization benchmark to ci #593

merged 14 commits into from
Jul 14, 2023

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Jul 10, 2023 •
edited
Loading

Description

What is changing?

New Benchmark infrastructure
  • Added benchmark infrastructure under test/bench with suites living under test/bench/suites
Migrate String deserialization benchmark
  • String deserialization benchmark added in test/bench/string_deserialization.ts
    • Checks with utf8 validation disabled and enabled
New CI tasks
  • Added new ci tasks for running benchmarks using web and node versions of bson
  • Tasks run on rhel 9.0 perf distribution
Is there new documentation needed for these changes?

No

What is the motivation for this change?

NODE-5403

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

W-A-James
W-A-James commented Jul 11, 2023
View reviewed changes
W-A-James
W-A-James commented Jul 11, 2023
View reviewed changes
W-A-James
W-A-James commented Jul 11, 2023
View reviewed changes
@W-A-James W-A-James changed the title test(NODE-5403): add benchmark to ci test(NODE-5403): add string deserialization benchmark to ci Jul 11, 2023
@W-A-James W-A-James changed the title test(NODE-5403): add string deserialization benchmark to ci ci(NODE-5403): add string deserialization benchmark to ci Jul 11, 2023
@W-A-James W-A-James marked this pull request as ready for review July 11, 2023 18:50
nbbeeken
nbbeeken reviewed Jul 11, 2023
View reviewed changes
@W-A-James W-A-James added the wip label Jul 12, 2023
@nbbeeken nbbeeken self-assigned this Jul 12, 2023
nbbeeken
nbbeeken suggested changes Jul 12, 2023
View reviewed changes
@W-A-James W-A-James requested a review from nbbeeken July 13, 2023 13:19
nbbeeken
nbbeeken suggested changes Jul 13, 2023
View reviewed changes
nbbeeken
nbbeeken suggested changes Jul 13, 2023
View reviewed changes
@W-A-James W-A-James requested a review from nbbeeken July 13, 2023 20:14
@nbbeeken nbbeeken removed the wip label Jul 13, 2023
@nbbeeken nbbeeken added the Team Review Needs review from team label Jul 13, 2023
@nbbeeken nbbeeken merged commit 2dfc125 into main Jul 14, 2023
@nbbeeken nbbeeken deleted the NODE-5403 branch July 14, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @nbbeeken