Skip to content

ci(NODE-5482): Append node version to evergreen benchmark task #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2023
Merged

ci(NODE-5482): Append node version to evergreen benchmark task #600

merged 2 commits into from
Jul 24, 2023

Conversation

W-A-James
Copy link
Contributor

Description

What is changing?

Append node version to evergreen benchmark task

Is there new documentation needed for these changes?

No

What is the motivation for this change?

NODE-5482

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as ready for review July 21, 2023 18:48
nbbeeken
nbbeeken suggested changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EVG says the config file is invalid, do we need quotes or something?

@nbbeeken nbbeeken self-assigned this Jul 24, 2023
@nbbeeken nbbeeken added the Team Review Needs review from team label Jul 24, 2023
@W-A-James W-A-James requested a review from nbbeeken July 24, 2023 15:16
@nbbeeken nbbeeken merged commit c0086c9 into main Jul 24, 2023
@nbbeeken nbbeeken deleted the NODE-5482 branch July 24, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @nbbeeken