test(NODE-5603): use npm 9 on eol node versions #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
suggested changes
Sep 5, 2023
W-A-James
suggested changes
Sep 5, 2023
W-A-James
added
the
Primary Review
durran
force-pushed
the
NODE-5603
branch
2 times, most recently
from
4485328 to
d97daed
Compare
W-A-James
suggested changes
Sep 6, 2023
dariakp
requested changes
Sep 6, 2023
baileympearson
previously approved these changes
Sep 7, 2023
W-A-James
approved these changes
Sep 7, 2023
|
All changes requested have been addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Node 16 failures with npm 10.
What is changing?
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-5603
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript