-
Notifications
You must be signed in to change notification settings - Fork 258
feat(NODE-6156): add signature to github releases #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
df748cf
temp for reset
aditi-khare-mongoDB e1ee129
read me changes
aditi-khare-mongoDB 34e269e
update 5.x script as well
aditi-khare-mongoDB 1845ce1
gh release
aditi-khare-mongoDB cbc738a
remove extraneous files
aditi-khare-mongoDB 9df488d
for testing
aditi-khare-mongoDB c3e4b89
lint fix
aditi-khare-mongoDB 968ec1c
for test
aditi-khare-mongoDB ef8c0b4
ready for review
aditi-khare-mongoDB 9d43c3e
fix for testing
aditi-khare-mongoDB 04428a3
fork testing
aditi-khare-mongoDB 5e166a8
local test
aditi-khare-mongoDB 203344c
local test 2
aditi-khare-mongoDB 407fb15
local test 3
aditi-khare-mongoDB 7528b2f
local test 4g
aditi-khare-mongoDB 5ae211b
local test 5
aditi-khare-mongoDB fe2b0d3
local test 6
aditi-khare-mongoDB 09137b5
local test 7
aditi-khare-mongoDB 9a70bb1
local test 8'
aditi-khare-mongoDB e901a41
local test 9
aditi-khare-mongoDB d3b4ded
local test 10
aditi-khare-mongoDB 998af93
local test 11
aditi-khare-mongoDB 753af4b
local test 12
aditi-khare-mongoDB bcb2e29
ready for review
aditi-khare-mongoDB 0634629
lint fix
aditi-khare-mongoDB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
name: Compress and Sign | ||
description: 'Compresses package and signs with garasign' | ||
|
||
inputs: | ||
garasign_username: | ||
description: 'Garasign username input for drivers-github-tools/garasign/gpg-sign' | ||
required: true | ||
garasign_password: | ||
description: 'Garasign password input for drivers-github-tools/garasign/gpg-sign' | ||
required: true | ||
artifactory_username: | ||
description: 'Artifactory username input for drivers-github-tools/garasign/gpg-sign' | ||
required: true | ||
artifactory_password: | ||
description: 'Artifactory password input for drivers-github-tools/garasign/gpg-sign' | ||
required: true | ||
|
||
runs: | ||
using: composite | ||
steps: | ||
- run: npm pack | ||
shell: bash | ||
|
||
- name: Get release version and release package file name | ||
id: vars | ||
shell: bash | ||
run: | | ||
package_version=$(jq --raw-output '.version' package.json) | ||
echo "package_version=${package_version}" >> "$GITHUB_OUTPUT" | ||
echo "package_file=bson-${package_version}.tgz" >> "$GITHUB_OUTPUT" | ||
|
||
- name: Create detached signature | ||
uses: mongodb-labs/drivers-github-tools/garasign/gpg-sign@v1 | ||
with: | ||
filenames: ${{ steps.vars.package_file }} | ||
garasign_username: ${{ inputs.garasign_username }} | ||
garasign_password: ${{ inputs.garasign_password }} | ||
artifactory_username: ${{ inputs.artifactory_username }} | ||
artifactory_password: ${{ inputs.artifactory_password }} | ||
|
||
- name: "Upload release artifacts" | ||
run: gh release upload v${{ steps.vars.package_version }} ${{ steps.vars.package_file }}.sig | ||
shell: bash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,25 @@ You can learn more about it in [the specification](http://bsonspec.org). | |
- [Documentation](#documentation) | ||
- [FAQ](#faq) | ||
|
||
|
||
### Release Integrity | ||
|
||
The GitHub release contains a detached signature file for the NPM package (named | ||
`bson-X.Y.Z.tgz.sig`). | ||
|
||
The following command returns the link npm package. | ||
```shell | ||
npm view [email protected] dist.tarball | ||
``` | ||
|
||
Using the result of the above command, a `curl` command can return the official npm package for the release. | ||
|
||
To verify the integrity of the downloaded package, run the following command: | ||
```shell | ||
gpg --verify bson-X.Y.Z.tgz.sig bson-X.Y.Z.tgz | ||
``` | ||
|
||
|
||
## Bugs / Feature Requests | ||
|
||
Think you've found a bug? Want to see a new feature in `bson`? Please open a case in our issue management tool, JIRA: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.