Skip to content

chore: incorrectly attempting access to sign release artifacts variables #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
May 29, 2024
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
df748cf
temp for reset
aditi-khare-mongoDB May 22, 2024
e1ee129
read me changes
aditi-khare-mongoDB May 22, 2024
34e269e
update 5.x script as well
aditi-khare-mongoDB May 22, 2024
1845ce1
gh release
aditi-khare-mongoDB May 22, 2024
cbc738a
remove extraneous files
aditi-khare-mongoDB May 22, 2024
9df488d
for testing
aditi-khare-mongoDB May 23, 2024
c3e4b89
lint fix
aditi-khare-mongoDB May 23, 2024
968ec1c
for test
aditi-khare-mongoDB May 23, 2024
ef8c0b4
ready for review
aditi-khare-mongoDB May 23, 2024
9d43c3e
fix for testing
aditi-khare-mongoDB May 23, 2024
04428a3
fork testing
aditi-khare-mongoDB May 23, 2024
5e166a8
local test
aditi-khare-mongoDB May 23, 2024
203344c
local test 2
aditi-khare-mongoDB May 23, 2024
407fb15
local test 3
aditi-khare-mongoDB May 23, 2024
7528b2f
local test 4g
aditi-khare-mongoDB May 23, 2024
5ae211b
local test 5
aditi-khare-mongoDB May 23, 2024
fe2b0d3
local test 6
aditi-khare-mongoDB May 23, 2024
09137b5
local test 7
aditi-khare-mongoDB May 23, 2024
9a70bb1
local test 8'
aditi-khare-mongoDB May 23, 2024
e901a41
local test 9
aditi-khare-mongoDB May 23, 2024
d3b4ded
local test 10
aditi-khare-mongoDB May 23, 2024
998af93
local test 11
aditi-khare-mongoDB May 23, 2024
753af4b
local test 12
aditi-khare-mongoDB May 23, 2024
bcb2e29
ready for review
aditi-khare-mongoDB May 23, 2024
0634629
lint fix
aditi-khare-mongoDB May 23, 2024
dfce69a
for testing
aditi-khare-mongoDB May 28, 2024
be29037
test test test....
aditi-khare-mongoDB May 28, 2024
115d94f
test 222
aditi-khare-mongoDB May 28, 2024
9048c98
remove bad subs
aditi-khare-mongoDB May 28, 2024
6247d68
test test ...
aditi-khare-mongoDB May 28, 2024
438550e
added env
aditi-khare-mongoDB May 28, 2024
37cab6b
ready for review
aditi-khare-mongoDB May 28, 2024
74b1594
temp change for conflict resolution
aditi-khare-mongoDB May 28, 2024
ef21d8b
Merge branch 'main' into NODE-6156/sign-release-artifacts
aditi-khare-mongoDB May 28, 2024
d732edf
ready for review
aditi-khare-mongoDB May 28, 2024
c59dbb6
newline
aditi-khare-mongoDB May 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/actions/compress_sign_and_upload/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,23 @@ runs:
shell: bash

- name: Get release version and release package file name
id: vars
id: get_vars
shell: bash
run: |
package_version=$(jq --raw-output '.version' package.json)
echo "package_version=${package_version}" >> "$GITHUB_OUTPUT"
echo "package_file=bson-${package_version}.tgz" >> "$GITHUB_OUTPUT"

- name: Create detached signature
uses: mongodb-labs/drivers-github-tools/garasign/gpg-sign@v1
with:
filenames: ${{ steps.vars.package_file }}
filenames: ${{ steps.get_vars.outputs.package_file }}
garasign_username: ${{ inputs.garasign_username }}
garasign_password: ${{ inputs.garasign_password }}
artifactory_username: ${{ inputs.artifactory_username }}
artifactory_password: ${{ inputs.artifactory_password }}

- name: "Upload release artifacts"
run: gh release upload v${{ steps.vars.package_version }} ${{ steps.vars.package_file }}.sig
shell: bash
run: gh release upload v${{ steps.get_vars.outputs.package_version }} ${{ steps.get_vars.outputs.package_file }}.sig
shell: bash
env:
GH_TOKEN: ${{ github.token }}