Change access specifier on $operators property #1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…query builder class Fixes mongodb#1077
|
Will this break previous Laravel releases? |
|
@jenssegers, no, it won't. Access level can get weaker but not stronger. I tested this here: https://3v4l.org/9BVb9 |
|
Cool |
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
…query builder class (mongodb#1086) Fixes mongodb#1077
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is made to match the access specifier in Laravel's base Query Builder class. This was changed in Laravel 5.4.
Fixes #1077