Updates PasswordBroker to work with Laravel 5.4 #1095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you use this to compare the version? http://php.net/manual/en/function.version-compare.php |
|
Sure I'll try to get that done soon, thanks! |
|
@jenssegers Doesn't seem like this is needed any longer? |
Should be closed, merged in #1162 Thank you for your contribution. cc @Smolevich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bad code alert:
This code is a shim until new dot release is available. As reset-password isn't used as often as other functions, the version check's added process should be negligible, but it still isn't the best way, obviously.
TODO: Remove check for next dot release (non-compatible with Laravel < 5.4).
PR Info:
Laravel 5.4 implements Hasher into
DatabaseTokenRepositoryand therefore requires this parameter to be passed to it fromPasswordBrokerManager.phpin laravel-mongodb.This PR adds a check to see if we're on 5.4+ and passes hasher if so, allowing it to remain compatible with prior versions of Laravel.