Fixed "Error parsing [float] as 64-bit integer" in Model::freshTimestamp()

[macdabby]

Fixes an error when round(microtime(true) * 1000) works out to be a float. Running in HHVM 3.15.4

#712

[jenssegers]

Can you change the casting to (int)?

[macdabby]

Absolutely - done!

[ghobaty]

@jenssegers @macdabby 4 byte integer overflow?!

microtime(true) = 1487826998.2899
microtime(true) * 1000 = 1487826998289.9
round(microtime(true) * 1000) = 1487826998290
(int) round(microtime(true) * 1000) = 1768313874

new UTCDateTime((int) round(microtime(true) * 1000)) will evaluate to a 1970-ish date.

[macdabby]

It looks like 32bit PHP will overflow as you are experiencing. It also looks like a float should work with this function, and this is more likely a bug in HHVM. I'll create a PR to revert this change.

[macdabby]

This function should also accept null to use the current time. @jenssegers should we use that instead?

[jenssegers]

@macdabby Wow, why didn't we see that. Are you up for making a PR? I'll get it merged.