Change Carbon include to fix SerializeUsing & jsonSerialize incosistency #1378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the Carbon include to use the extended version of Laravel.
`use Carbon\Carbon` => `use Illuminate\Support\Carbon`
This way we can use the `jsonSerialize()` and `serializeUsing`.
For example in the new ApiResources in Laravel 5.5 we can specify a global serialization for Carbon dates:
````Carbon::serializeUsing(function ($carbon) {
return $carbon->format('U');
});````
https://laravel.com/docs/5.5/eloquent-serialization#date-serialization
Christophvh
changed the title
Christophvh
changed the title
Christophvh
changed the title
Christophvh
changed the title
Christophvh
changed the title
|
Hello! Could you please update with the base branch or we can take a look? Thank you for your contribution! |
|
It can be closed @jenssegers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the Carbon include to use the extended version of Laravel.
use Carbon\Carbon => use Illuminate\Support\CarbonThis way we can use the
jsonSerialize()andserializeUsing(). methodsFor example in the new ApiResources in Laravel 5.5 we can specify a global serialization for Carbon dates:
https://laravel.com/docs/5.5/eloquent-serialization#date-serialization