Skip to content

Refactoring tests #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Refactoring tests #1385

merged 1 commit into from
Dec 22, 2017

Conversation

carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Dec 8, 2017

I've refactored several tests, using:

  • assertCount instead of count function;
  • assertInternalType instead of is_* functions;
  • assertArrayHasKey and assertArrayNotHasKey instead of array_key_exists function;
  • assertTrue instead of comparison with true keyword;
  • assertFalse instead of comparison with false keyword;
  • assertNull instead of comparison with null keyword;
  • assertContains and assertNotContains instead of in_array function;
  • assertObjectNotHasAttribute instead of isset function;
  • assertLessThan for mathematical comparisons.

@jenssegers jenssegers merged commit 8895014 into mongodb:master Dec 22, 2017
@jenssegers
Copy link
Contributor

Thanks!

@carusogabriel carusogabriel deleted the refactoring-tests branch December 22, 2017 14:37
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants