fix dsn config when not unix socket #1457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halaei
force-pushed
the
fix-dsn-when-not-unix-socket
branch
from
aca8ac0 to
0e69388
Compare
|
|
|
merge this pull request, please!!!!!! |
hlorofos
added a commit
to hlorofos/laravel-mongodb
that referenced
this pull request
Apr 19, 2018
|
This is a great package. It is sad that the issues and pull requests are not handled as fast as they could be. Probably the owner, @jenssegers, needs some maintenance help? |
|
I would like to offer my help in any way in order to push this live. #1397 broke many things at once |
|
Sorry for the delay! |
This was referenced Feb 9, 2020
softdevee
added a commit
to softdevee/laravel-mongodb
that referenced
this pull request
Sep 5, 2022
lisadeloach63
added a commit
to lisadeloach63/mongodb-laravel
that referenced
this pull request
Oct 7, 2022
PermitinYury
pushed a commit
to PermitinYury/laravel-mongodb
that referenced
this pull request
Feb 17, 2023
KarenEtheridg
pushed a commit
to KarenEtheridg/laravel-mongodb
that referenced
this pull request
Feb 17, 2023
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
fix dsn config when not unix socket
Giant775
added a commit
to Giant775/laravel_MongoDB
that referenced
this pull request
Nov 15, 2024
dev-arrow
added a commit
to dev-arrow/laravel-mongodb
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is assumed in #1397 that dsn is only for unix sockets. But the assumption is wrong, causing issues #1456 and #1449
IMO, a better approach would be having a separate
unix_socketconfig to be encoded viarawurlencode()in this package or just let the users callrawurlencode()themselves when providing such URIs in 'dsn'.Closes: #1456, #1449