Changes in travis build #1553
Merged
Changes in travis build #1553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jenssegers, can you review, please? |
jenssegers
reviewed
Jun 27, 2018
docker-compose.yml
Outdated
| @@ -10,6 +9,8 @@ services: | |||
| volumes: | |||
| - .:/code | |||
| working_dir: /code | |||
| environment: | |||
| PHP_VERSION: ${PHP_VERSION} | |||
There was a problem hiding this comment.
This can be a fixed value I guess, or at least provide a default value. Could you change this?
Great job on these changes btw!
There was a problem hiding this comment.
Yes, i can set default value, but env variable PHP_VERSION set in travis script build
There was a problem hiding this comment.
Also in Docker file i popose operation installing composer to replace on this construction
FROM composer as composer-build #official docker image with composer (https://github.com/composer/docker/blob/master/1.6/Dockerfile)
COPY --from=composer-build /usr/bin/composer /usr/local/bin/composer
|
@jenssegers, can you review changes? |
|
Great work! |
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
Changes in travis build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my opinion we don't need execute sed command in
.travis.ymlbecause Docker engine has arguments in Dockerfile and we can use itDockerfile.travis.ymlfrom env variableTRAVIS_PHP_VERSIONzlib1g-devreplaced frompecl installtoapt-get install