update readme #1830
Closed
update readme #1830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giacomo92
approved these changes
Jan 20, 2020
Giacomo92
reviewed
Jan 20, 2020
| @@ -318,7 +318,7 @@ If you want to use MongoDB to handle failed jobs, change the database in `config | |||
|
|
|||
| ```php | |||
| 'failed' => [ | |||
| 'database' => 'mongodb', | |||
| 'database' => env('DB_CONNECTION', 'mongodb'), | |||
There was a problem hiding this comment.
why not 'database' => env('DB_DATABASE', 'mongodb'),?
|
I think we can close this PR because fork repo was deleted |
|
@jenssegers what do you think about this? |
|
@Smolevich I think this can be added in a new PR |
Merged
|
This needs to closed but merged in #1917 |
|
Issued a commit here: #1917 |
sorry for deleting repo I thought it was not necessary change :) |
|
@ahmedsayedabdelsalam, it's ok, sorry for late response from us |
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I this it will be better to read the DB of faild jobs from env file (default DB connection) and fallback on mongodb instead of referencing it statically.