Skip to content

fix tests without assertions #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

denissonleal
Copy link
Contributor

@denissonleal denissonleal commented Oct 17, 2019

these two test cases doesn't have assertions and the phpunit shows errors because of that

@Smolevich
Copy link
Contributor

Add description please

@denissonleal
Copy link
Contributor Author

denissonleal commented Oct 17, 2019

fails shown in phpunit:

.R.............................................................  63 / 186 ( 33%)
............................................................... 126 / 186 ( 67%)
......................................................R.....    186 / 186 (100%)

Time: 1.27 minutes, Memory: 64.00 MB

There were 2 risky tests:

1) AuthTest::testRemindOld
This test did not perform any assertions

/code/tests/AuthTest.php:28

2) SchemaTest::testDummies
This test did not perform any assertions

/code/tests/SchemaTest.php:297

OK, but incomplete, skipped, or risky tests!
Tests: 186, Assertions: 779, Risky: 2.

@jenssegers jenssegers merged commit 89861b6 into mongodb:master Oct 18, 2019
@jenssegers
Copy link
Contributor

Thanks!

mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
…orm-assertion

fix tests without assertions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants