Add support for GitHub actions #1859
Conversation
|
@jenssegers , can you review please? |
|
@jenssegers example of coveralls report |
|
@jenssegers can you review please? |
|
@jenssegers, can you review please? |
|
php-coveralls/php-coveralls#275 pr with changes for support GitHub Actions |
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| php: [7.1, 7.2, 7.3] |
There was a problem hiding this comment.
Since 7.4 is out is that something we want to look at supporting?
There was a problem hiding this comment.
We cann add 7.4 to matrix in any time
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| $mongoHost = env('MONGO_HOST', 'mongodb'); | |||
| $mongoPort = env('MONGO_PORT') ? (int) env('MONGO_PORT') : 27017; | |||
| $mysqlPort = env('MYSQL_PORT') ? (int) env('MYSQL_PORT') : 3306; | |||
|
|
|||
There was a problem hiding this comment.
since we are starting the mysql service on port 3307, if for some reason the env variable isn't set will this connect?
There was a problem hiding this comment.
or can to connect or connect was failed
| env: | ||
| MONGO_HOST: 0.0.0.0 | ||
| MYSQL_HOST: 0.0.0.0 | ||
| MYSQL_PORT: 3307 |
There was a problem hiding this comment.
Do we need to set env vars before we run phpunit?
Also I see we are setting the MYSQL_PORT to 3306 in the phpunit.xml.dist, will that overwrite our 3307 from this?
There was a problem hiding this comment.
env variable MYSQL_PORT override value in phpunit.xml
Smolevich
force-pushed
the
add-support-for-github-actions
branch
5 times, most recently
from
3b05bcf to
adb57c2
Compare
Smolevich
force-pushed
the
add-support-for-github-actions
branch
from
adb57c2 to
a51a266
Compare
|
How do I check if this is working? :) |
|
I saw that it ran fine on your fork 👍 |
|
Failed build with this problem php-coveralls/php-coveralls#275 |
…-actions Add support for GitHub actions
Uh oh!
There was an error while loading. Please reload this page.