-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[3.x] fix truncate to delete items in collection #1993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lection Resolves: #1306
Codecov Report
@@ Coverage Diff @@
## master #1993 +/- ##
============================================
- Coverage 87.04% 87.03% -0.01%
Complexity 667 667
============================================
Files 31 31
Lines 1521 1520 -1
============================================
- Hits 1324 1323 -1
Misses 197 197
Continue to review full report at Codecov.
|
This should be pushed to |
Sorry this is my first ever pull request and i'm not quite sure how to correct the things you guys have told me. How can i "append" a new commit to this pull request? Or should i make a new pr on the develop branch? |
I think that you left this PR |
Just edit your https://github.com/Yahatix/laravel-mongodb and changes will be reflected here. -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you @Yahatix
Codecov Report
@@ Coverage Diff @@
## master #1993 +/- ##
============================================
- Coverage 86.89% 86.88% -0.01%
Complexity 671 671
============================================
Files 31 31
Lines 1557 1556 -1
============================================
- Hits 1353 1352 -1
Misses 204 204
Continue to review full report at Codecov.
|
@Smolevich any objections? |
[3.x] fix truncate to delete items in collection
Make the truncate function only remove documents and not drop the collection
Resolves: #1306