Skip to content

Add test for date with multiple formats #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2020
Merged

Add test for date with multiple formats #2027

merged 5 commits into from
Apr 28, 2020

Conversation

Giacomo92
Copy link

No description provided.

@Giacomo92 Giacomo92 mentioned this pull request Apr 22, 2020
Closed
@Giacomo92 Giacomo92 changed the title Add test for negative dates cast Add test for negative timestamp cast into Carbon instance Apr 22, 2020
@Smolevich
Copy link
Contributor

@Giacomo92, this PR only for tests?

@Giacomo92
Copy link
Author

Giacomo92 commented Apr 23, 2020 •
edited
Loading

Hi @Smolevich , I was trying to investigate and solve issue #2026 but @DFurnes has just released a fix. Anyway I would like to add more date test with different date format, just to be sure to handle all cases.

@codecov-io
Copy link

codecov-io commented Apr 23, 2020 •
edited
Loading

Codecov Report

Merging #2027 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2027   +/-   ##
=========================================
  Coverage     87.15%   87.15%           
  Complexity      672      672           
=========================================
  Files            31       31           
  Lines          1541     1541           
=========================================
  Hits           1343     1343           
  Misses          198      198

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736415e...44825e7. Read the comment docs.

@Giacomo92 Giacomo92 changed the title Add test for negative timestamp cast into Carbon instance Add test for date with multiple format Apr 27, 2020
@Giacomo92 Giacomo92 changed the title Add test for date with multiple format Add test for date with multiple formats Apr 27, 2020
@Giacomo92
Copy link
Author

check PR, please @Smolevich

@Smolevich Smolevich self-assigned this Apr 28, 2020
@Smolevich Smolevich merged commit 1898947 into mongodb:master Apr 28, 2020
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
@mnphpexpert
Merge pull request mongodb#2027 from Giacomo92/add_test_for_negative_…
3a8f425 
…dates

Add test for date with multiple formats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smolevich Smolevich Smolevich approved these changes

Assignees

@Smolevich Smolevich

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Giacomo92 @Smolevich @codecov-io