tests: for sorting #2039
Merged
tests: for sorting #2039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2039 +/- ##
=========================================
Coverage 87.15% 87.15%
Complexity 672 672
=========================================
Files 31 31
Lines 1541 1541
=========================================
Hits 1343 1343
Misses 198 198 Continue to review full report at Codecov.
|
Smolevich
approved these changes
May 29, 2020
|
@willtj thanks for contribution! |
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
tests: for sorting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for sorting results from MongoDB - first a test to ensure that the results are unsorted as expected when no sort is applied, then tests for single and multiple sorts with/without a sort order.
#1508 (and the fact that this was added to the v4 project board) seems to suggest that applying multiple sorts isn't supported, but everything seems to be working as expected unless I've totally misunderstood the issue?