Skip to content

Fix failed command in ci #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 7, 2020
Merged

Fix failed command in ci #2045

merged 5 commits into from
Jun 7, 2020

Conversation

Smolevich
Copy link
Contributor

  • PHP 7.1 was deleted from ci matrix (phpunit and cedx/coveralls require php>= 7.2)
  • Using action for setup php

@Smolevich Smolevich requested review from jenssegers and divine June 3, 2020 07:20
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #2045 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2045      +/-   ##
============================================
- Coverage     87.15%   86.90%   -0.25%     
  Complexity      672      672              
============================================
  Files            31       31              
  Lines          1541     1558      +17     
============================================
+ Hits           1343     1354      +11     
- Misses          198      204       +6     
Impacted Files Coverage Δ Complexity Δ
...rc/Jenssegers/Mongodb/Eloquent/HybridRelations.php 87.64% <0.00%> (-5.95%) 34.00% <0.00%> (ø%)
src/Jenssegers/Mongodb/Queue/MongoQueue.php 100.00% <0.00%> (ø) 10.00% <0.00%> (ø%)
src/Jenssegers/Mongodb/Relations/EmbedsMany.php 97.24% <0.00%> (+0.10%) 45.00% <0.00%> (ø%)
src/Jenssegers/Mongodb/Eloquent/Builder.php 87.93% <0.00%> (+0.21%) 22.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7f5c1...31ee326. Read the comment docs.

Copy link
Contributor

@divine divine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Smolevich
Copy link
Contributor Author

Smolevich commented Jun 3, 2020

@jenssegers please refresh old cache for ci matrix
Снимок экрана 2020-06-03 в 11 19 21
These steps was deleted

@divine
Copy link
Contributor

divine commented Jun 7, 2020

@jenssegers ping 😢

@jenssegers
Copy link
Contributor

@Smolevich will do!

@jenssegers jenssegers merged commit 1375cdd into master Jun 7, 2020
@divine divine deleted the fix-failed-command-in-ci branch June 7, 2020 09:22
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants