PHPORM-31 Split documentation into multiple files #2610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
requested changes
Sep 8, 2023
alcaeus
approved these changes
Sep 11, 2023
| RUN composer install | ||
|
|
||
| CMD ["./vendor/bin/phpunit", "--testdox"] | ||
| CMD ["bash", "-c", "composer install && ./vendor/bin/phpunit --testdox"] |
There was a problem hiding this comment.
Out of curiosity, what's the advantage of moving composer install into CMD from its separate RUN? Does it mean that the built image will be without composer dependencies and they will be installed before running tests?
There was a problem hiding this comment.
The working directory is mounted into the container by docker-compose, so dependencies installed the docker image are ignored.
Also, if you ran composer install with PHP 8.2 locally and try to run phpunit in the container with PHP 8.1, it will fail. That's also why I add config.platform.php: 8.1 in composer.json
alcaeus
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-31
MongoDBServiceProvider