Skip to content

Remove changelog. Use release notes instead #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Nov 6, 2023

Release notes are a lot easier to update and maintain.

@GromNaN GromNaN requested a review from alcaeus November 6, 2023 09:15
@GromNaN GromNaN changed the base branch from 4.1 to 4.0 November 6, 2023 09:16
@GromNaN GromNaN added this to the 4.0 milestone Nov 6, 2023
@divine
Copy link
Contributor

divine commented Nov 6, 2023

Sorry but I’m not sure why this type of hard decision is made by MongoDB PHP Team? This and other changes definitely needs some proper reviews instead of instant merge like what happened with other PRs without review sadly.

Just interesting what type of reaction this could get in a Symfony or Laravel repositories? Is that hard to keep the changelog for the users or just get some automation done right?

Thanks!

@GromNaN
Copy link
Member Author

GromNaN commented Nov 6, 2023

Hello @divine, thanks for your feedback. I get that you created this changelog file some time ago and you have been the only one to maintain it. Currently we don't have a changelog in the mongodb library project and everything is documented in release notes.

GitHub provides a good automation with generated release notes, that we customize on each release. What advantage do you see in keeping this file?

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. While it may seem convenient, the changelog file requires manual updating, whereas generating a changelog as part of the release notes can be done automatically. In addition to those automated lists (which GitHub generates based on commits to the branch since the last release) we highlight significant changes in the release notes, usually in more detail than the changelog would. I believe that negates the necessity for manually maintaining this file.

Instead, we should consider introducing an UPGRADE file containing incompatible changes to point out changes that require intervention by the user (e.g. to prepare for a major release).

@GromNaN GromNaN mentioned this pull request Nov 21, 2023
3 tasks
@GromNaN
Copy link
Member Author

GromNaN commented Nov 22, 2023

Closing in favor of #2684

@GromNaN GromNaN closed this Nov 22, 2023
@GromNaN GromNaN deleted the remove-changelog branch November 22, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants