-
Notifications
You must be signed in to change notification settings - Fork 1.5k
DOCSP-35932: compatibility page #2714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-35932: compatibility page #2714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm + 1 question
|
||
* - {+odm-short+} Version | ||
- Laravel 10.x | ||
- Laravel 9.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Is "9.x" here just for completeness? Or do we expect to use it in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not expected. I think it's for completeness because we didn't import the original table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included it for completeness since it's currently a supported version of Laravel, so users might wonder whether it is compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may add the first line of the table then.
9.x | 3.9.x | ❌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then this doesn't tell which version is supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I interpreted this as 3.9.x is incompatible with 10.x, but is compatible with 9.x and added that row to the new table. Is that incorrect? Would you like me to keep/remove/change anything before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I mean 3.9 is no longer maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, so if I understand correctly, we should also inform the reader which versions are maintained. Do you think it would be better to omit this line since there are several unmaintained versions of Laravel MongoDB prior to 3.9? Or if you want to keep it, I can add a line of text or footnote that mentions that 3.9 isn't maintained anymore. Let me know what works best for you, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets remove this last line then. We already have a link to the old versions table.
Compatibility for supported versions of Laravel and Laravel MongoDB.
JIRA - https://jira.mongodb.org/browse/DOCSP-35932
Staging:
Checklist