PHPORM-164 Run tests with PHP 8.4 #2830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
PHPORM-164
branch
3 times, most recently
from
85bae41 to
a5f3767
Compare
alcaeus
reviewed
Apr 9, 2024
GromNaN
force-pushed
the
PHPORM-164
branch
2 times, most recently
from
6e72c12 to
87f4912
Compare
|
Single deprecation issue to be fixed by spatie/laravel-ray#340 |
jmikola
reviewed
Apr 10, 2024
| @@ -31,6 +31,12 @@ jobs: | |||
| laravel: "10.*" | |||
| mongodb: "5.0" | |||
| mode: "low-deps" | |||
| os: "ubuntu-latest" | |||
| - php: "8.4" | |||
There was a problem hiding this comment.
Do you want to allow failures on 8.4, or wait until spatie/laravel-ray#340 is merged?
There was a problem hiding this comment.
I'll see tomorrow, depending on how responsive the maintainers are.
There was a problem hiding this comment.
Waiting for the branch alias to be fixed spatie/laravel-ray#341, or the fix to be released.
There was a problem hiding this comment.
New package update: spatie/ray#903
|
All good, the 3rd party packages are fixed. |
jmikola
approved these changes
Apr 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-164
See what's new in PHP 8.4 on php.watch.
We have no implicitly nullable arguments. So nothing to fix so far.
Checklist