DOCSP-35959: search text #2889
DOCSP-35959: search text #2889
Conversation
| Search Text Fields | ||
| ------------------ | ||
|
|
||
| You can perform a text search by using the :manual:`$text |
There was a problem hiding this comment.
Suggestion:
I think it could be better to swap this paragraph (describes how to perform one) with the one following it (describes what a text search is). The first paragraph also seems more connected to the third paragraph ("After building your query...").
| This example calls the ``where()`` method on the ``Movie`` Eloquent model to | ||
| retrieve documents in which the ``plot`` field contains the phrase | ||
| ``"love story"``: |
There was a problem hiding this comment.
Issue:
I think the creation of the index needs to be mentioned or shown to understand that "plot" is the indexed field.
Suggestion:
I think either mentioning that the text index was created on the "plot" field or showing an example of creating the index similar to this Java documentation would help a reader understand the connection.
There was a problem hiding this comment.
I mentioned this in the note, but I can also add a sentence that explains that the example assumes a text index on the plot field
| .. note:: | ||
|
|
||
| To specify a phrase as the text search criteria, you must include it | ||
| with escaped quotes in the query filter. |
There was a problem hiding this comment.
Question:
Perhaps a question for the technical reviewer, but is it possible to use single quotes instead of double quotes to represent the value of the $search key (which would hopefully avoid having to escape the quotes and concatenate strings)?
There was a problem hiding this comment.
I use single quote everywhere, unless I want to use variable injection with double quotes.
There was a problem hiding this comment.
tested this improvement and it works! removing the admonition
| { | ||
| public function show() | ||
| { | ||
| $movies = Movie::where('$text', ['$search' => "\"" . 'love story' . "\""]) |
There was a problem hiding this comment.
Sure it's better like this. The doubles quotes will probably come from user input.
| $movies = Movie::where('$text', ['$search' => "\"" . 'love story' . "\""]) | |
| $movies = Movie::where('$text', ['$search' => '"love story"']) |
There was a problem hiding this comment.
thanks for this improvement! Was struggling to make this work, didnt realize the solution was so simple.
GromNaN
force-pushed
the
DOCSP-35959-search-text
branch
from
461bef2 to
802f50e
Compare
…-mongodb into DOCSP-35959-search-text
JIRA
STAGING
docs PR
Checklist