DOCSP-35939: tls

[rustagir]

https://jira.mongodb.org/browse/DOCSP-35939

STAGING

Docs PR - https://github.com/10gen/docs-laravel/pull/69

Checklist

• Add tests and ensure they pass
• Add an entry to the CHANGELOG.md file
• Update documentation for new features

[ccho-mongodb]

Looks great -- I think a few straightforward tweaks could improve the focus of the content. I don't think I need to review again, but happy to take another look if you want.

[ccho-mongodb]

Suggestion:

In the referenced link, it's not clear to me which settings are safe to use. The driverOptions settings, such as such as ca_file, pem_file, and pem_pwd, on the page are described as "deprecated alias for the [option name] URI option" .

I think it could be helpful to mention which settings to recommend since it's not clear on the linked page. Maybe @GromNaN can provide more guidance here.

[GromNaN]

I'd ask @jmikola. I don't know this option. I learned about this feature by reading your doc.

[jmikola]

The URI options prefixed with tls supersede the driverOptions. There are very few options that are only supported through driverOptions (e.g. crl_file), and I don't think any of those are relevant to these docs.

I think the right call is to remove any discussion of driverOptions. You can still link to the Manager constructor as canonical documentation for URI options, though. In that case, you can drop a link to it in the "Additional Information" section below (probably above the server docs, since it will be more relevant to PHP).

---

driverOptions property

Is this actually a property in the Laravel configuration? If you're referring to the Manager constructor, then the proper terminology would be "driverOptions parameter" (not "property").

But this may be a moot point since the entire note can be removed.

[jmikola]

The URI options prefixed with tls supersede the driverOptions. There are very few options that are only supported through driverOptions (e.g. crl_file), and I don't think any of those are relevant to these docs.

I think the right call is to remove any discussion of driverOptions. You can still link to the Manager constructor as canonical documentation for URI options, though. In that case, you can drop a link to it in the "Additional Information" section below (probably above the server docs, since it will be more relevant to PHP).

---

driverOptions property

Is this actually a property in the Laravel configuration? If you're referring to the Manager constructor, then the proper terminology would be "driverOptions parameter" (not "property").

But this may be a moot point since the entire note can be removed.

[GromNaN]

I leave it to @jmikola to approve.

[jmikola]

LGTM. I'll leave you to address the tlsInsecure documentation on your own and don't need to review that a second time.

[jmikola]

Quoting https://www.php.net/manual/en/mongodb-driver-manager.construct.php:

Specifying true for this option has the same effect as specifying true for both the "tlsAllowInvalidCertificates" and "tlsAllowInvalidHostnames" URI options. Defaults to false.

There should be no reason for the user to specify all three options. The improvement here would be to note that tlsInsecure implies the other two options.

Sorry for missing this earlier. This change should probably be applied to whatever content this was copied/adapted from (assuming other driver docs would be affected).

[norareidy]

lgtm