DOCSP-38344: docs cleanup #2902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
approved these changes
Apr 23, 2024
Comment on lines
78
to
80
| - Specify ``"mongodb"`` in the ``$connection`` field of your migration class | ||
| - Make sure your ``connections`` array item contains a valid ``mongodb`` | ||
| entry in your ``config/database.php`` file |
There was a problem hiding this comment.
s; reverse these items' order
rustagir
reviewed
Apr 23, 2024
norareidy
reviewed
Apr 23, 2024
GromNaN
approved these changes
Apr 26, 2024
|
|
||
| .. code-block:: php | ||
| :emphasize-lines: 2-6 | ||
|
|
||
| 'connections' => [ | ||
| 'mongodb' => [ | ||
| 'driver' => 'mongodb', | ||
| 'dsn' => env('DB_URI', '<connection string>'), | ||
| 'dsn' => env('DB_URI'), |
There was a problem hiding this comment.
Note that we can still set de default value mongodb://localhost:27017/. But that may confuse a beginner, so it's okay to remove the default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.mongodb.org/browse/DOCSP-38344
Staging:
https://preview-mongodbcchomongodb.gatsbyjs.io/laravel/DOCSP-38344-cleanup/
Related docs PR: https://github.com/10gen/docs-laravel/pull/74
Checklist