Skip to content

DOCSP-37770: Return results as JSON #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 6, 2024
Merged

DOCSP-37770: Return results as JSON #2921

merged 6 commits into from
May 6, 2024

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Apr 30, 2024

JIRA - https://jira.mongodb.org/browse/DOCSP-37770
Staging -
https://preview-mongodbnorareidy.gatsbyjs.io/laravel/DOCSP-37770/quick-start/view-data/#optionally--view-your-results-as-json-documents
https://preview-mongodbnorareidy.gatsbyjs.io/laravel/DOCSP-37770/query-builder/#before-you-get-started

Implementing the solution in this JIRA comment:

After investigation, the solution could be to add an optional task in the Quick Start to convert the result to JSON instead of HTML.

This section could be linked to by other docs as "To learn how to view the output..."

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file
  • Update documentation for new features

Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with some suggestions

Comment on lines 76 to 78
run the example code from a controller method. To see the expected code
output, use the ``toJson()`` method shown in the optional :ref:`View your results as JSON documents
<laravel-quick-start-json>` step of the Quick Start.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run the example code from a controller method. To see the expected code
output, use the ``toJson()`` method shown in the optional :ref:`View your results as JSON documents
<laravel-quick-start-json>` step of the Quick Start.
run the example code from a controller method. To see the expected code
output as JSON documents, use the ``toJson()`` method shown in the optional :ref:`View your results as JSON documents
<laravel-quick-start-json>` step of the Quick Start.

@norareidy norareidy requested a review from GromNaN April 30, 2024 21:13
@norareidy norareidy marked this pull request as ready for review May 1, 2024 19:42
@norareidy norareidy requested a review from a team as a code owner May 1, 2024 19:42
@norareidy norareidy merged commit d1802d1 into mongodb:4.1 May 6, 2024
15 checks passed
@norareidy norareidy deleted the DOCSP-37770-return-json branch May 6, 2024 14:49
@GromNaN GromNaN added the docs label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants