-
Notifications
You must be signed in to change notification settings - Fork 1.5k
DOCSP-38100: User authentication #3034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-38100: User authentication #3034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…y/laravel-mongodb into DOCSP-38100-user-authentication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes and suggestions but LGTM otherwise
docs/user-authentication.txt
Outdated
In this guide, you can learn how to authenticate users stored in MongoDB | ||
by using Laravel's native authentication functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: applies throughout
In this guide, you can learn how to authenticate users stored in MongoDB | |
by using Laravel's native authentication functionality. | |
In this guide, you can learn how to authenticate MongoDB users | |
by using Laravel's native authentication functionality. |
docs/user-authentication.txt
Outdated
In this guide, you can learn how to authenticate users stored in MongoDB | ||
by using Laravel's native authentication functionality. | ||
|
||
Laravel provides a native Auth module that includes authentication services, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: not sure whether this is standard for PHP/Laravel, but I'd guess it helps readability
Laravel provides a native Auth module that includes authentication services, | |
Laravel provides a native ``Auth`` module that includes authentication services, |
docs/user-authentication.txt
Outdated
must extend the ``MongoDB\Laravel\Auth\User`` class. | ||
|
||
To extend this class, navigate to your ``app/Models/User.php`` file and replace the | ||
``use Illuminate\Foundation\Auth\User as Authenticatable`` use statement with the following |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``use Illuminate\Foundation\Auth\User as Authenticatable`` use statement with the following | |
``use Illuminate\Foundation\Auth\User as Authenticatable`` statement with the following |
docs/user-authentication.txt
Outdated
|
||
use MongoDB\Laravel\Auth\User as Authenticatable; | ||
|
||
Ensure that your ``User`` class extends ``Authenticatable``, as shown in the following code: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: Might help to link this step to the previous one
Ensure that your ``User`` class extends ``Authenticatable``, as shown in the following code: | |
Next, ensure that your ``User`` class extends ``Authenticatable``, as shown in the following code: |
docs/user-authentication.txt
Outdated
After configuring your ``User`` model, create a corresponding controller. For instructions on | ||
creating a controller, see the :ref:`laravel-auth-controller` section on this page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I: on/about
After configuring your ``User`` model, create a corresponding controller. For instructions on | |
creating a controller, see the :ref:`laravel-auth-controller` section on this page. | |
After configuring your ``User`` model, create a corresponding controller. To learn how to | |
create a controller, see the :ref:`laravel-auth-controller` section on this page. |
docs/user-authentication.txt
Outdated
Example | ||
~~~~~~~ | ||
|
||
The following code demonstrates a ``User.php`` file that extends the ``MongoDB\Laravel\Auth\User`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: shows? displays? "demonstrates" is more active to me
The following code demonstrates a ``User.php`` file that extends the ``MongoDB\Laravel\Auth\User`` | |
The following code shows a ``User.php`` file that extends the ``MongoDB\Laravel\Auth\User`` |
JIRA - https://jira.mongodb.org/browse/DOCSP-38100
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/laravel/DOCSP-38100/user-authentication/
Checklist