-
Notifications
You must be signed in to change notification settings - Fork 1.5k
DOCSP-46230: atlas search index mgmt #3270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rustagir
merged 12 commits into
mongodb:5.x
from
rustagir:DOCSP-46230-atlas-search-mgmt
Feb 25, 2025
+355
−21
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
034c6e8
DOCSP-46230: atlas search index mgmt
rustagir 532172c
fix
rustagir 77d77f5
fix
rustagir 0f50065
small fix
rustagir 7efe5b1
wip
rustagir 95ea7e0
wip
rustagir 85fb2c9
wip
rustagir d1c2cfe
wip
rustagir 1b87a67
test php link
rustagir 2104ca7
test php link
rustagir b478ece
RM PR fixes 1
rustagir bd1463c
JT suggestion - move code to tests
rustagir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
use Illuminate\Database\Migrations\Migration; | ||
use Illuminate\Support\Facades\Schema; | ||
use MongoDB\Laravel\Schema\Blueprint; | ||
|
||
return new class extends Migration | ||
{ | ||
protected $connection = 'mongodb'; | ||
|
||
public function up(): void | ||
{ | ||
// begin-create-search-indexes | ||
Schema::create('galaxies', function (Blueprint $collection) { | ||
$collection->searchIndex([ | ||
'mappings' => [ | ||
'dynamic' => true, | ||
], | ||
], 'dynamic_index'); | ||
$collection->searchIndex([ | ||
'mappings' => [ | ||
'fields' => [ | ||
'name' => [ | ||
['type' => 'string', 'analyzer' => 'lucene.english'], | ||
['type' => 'autocomplete', 'analyzer' => 'lucene.english'], | ||
['type' => 'token'], | ||
], | ||
], | ||
], | ||
], 'auto_index'); | ||
}); | ||
// end-create-search-indexes | ||
|
||
// begin-create-vs-index | ||
Schema::create('galaxies', function (Blueprint $collection) { | ||
$collection->vectorSearchIndex([ | ||
'fields' => [ | ||
[ | ||
'type' => 'vector', | ||
'numDimensions' => 4, | ||
'path' => 'embeddings', | ||
'similarity' => 'cosine', | ||
], | ||
], | ||
], 'vs_index'); | ||
}); | ||
// end-create-vs-index | ||
} | ||
|
||
public function down(): void | ||
{ | ||
// begin-drop-search-index | ||
Schema::table('galaxies', function (Blueprint $collection) { | ||
$collection->dropSearchIndex('auto_index'); | ||
}); | ||
// end-drop-search-index | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the migration class is not actually displayed in the docs, you can move code snippets in
up
anddown
methods into unit tests that would validate them (ensure the index is correctly created) and deleted.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!