[WIP] LG-5026: Drawer Toolbar Integration 🛠️ #2866
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add toolbar * Updates Readme (#2806) * rm create-leafygreen-app * Update README.md * lint * add keyboard focus management * fix focus hijacking * naming * updates types, fixes focus on click * Toolbar focus state * fix error * add stories * toolbar generated stories * ToolbarIconButton generated stories * update comments * add testids and add an error if trying to use ToolbarIconButton outside of Toolbar * interaction tests * WIP test harnesses * test harnesses * toolbar specs * ToolbarIconButton specs * lint * pass className to styles * README * add missing deps * use test utils in interaction tests * changesets * remove darkMode from context * Use latest version of `useBackdropClick` (#2810) * upate hooks * with changeset * revert allowProp * fix ts error * some cleanup * add ref test * use correct test * remove iconButton changes * hellllllo * fix build error * Storybook export `findStories` (#2808) * update webpack * findStories args * changeset * Update index.ts * revert to getLGConfig * Updates `lg install` [LG-5040, LG-5041] (#2807) * updates lg install script * updates meta * adds --dry option to install command * changesets * adds package set flags * cli minor * fix install pkg prebuild * adds tests * updates lint scrips * lint all_packages file on write * run lint * Update getLGConfig.ts * Update getPackagesToInstall.ts * Update getPackagesToInstall.spec.ts * fix mocks * update flags to be additive * push not concat * Update getLGConfig.spec.ts * Update package.json * adds separate files for ESSENTIALS & BASIC * --ui * readonly<> * fix tests * Update pnpm-lock.yaml * add missing lodash * adds two new icons (#2815) * constants * update README * Version Packages (#2811) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * build error and export const * move handle click to context * unique test ids for toolbarIconButton * move test harnesses to testing dir * aria label check * update README * Add more descriptive labels to some toolbar icons --------- Co-authored-by: Adam Thompson <[email protected]> Co-authored-by: Brooke Scarlett Yalof <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: e2043f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* add toolbar * add keyboard focus management * fix focus hijacking * naming * updates types, fixes focus on click * Toolbar focus state * fix error * add stories * toolbar generated stories * ToolbarIconButton generated stories * update comments * add testids and add an error if trying to use ToolbarIconButton outside of Toolbar * interaction tests * WIP test harnesses * test harnesses * toolbar specs * ToolbarIconButton specs * lint * pass className to styles * README * add missing deps * use test utils in interaction tests * changesets * remove darkMode from context * fix ts error * some cleanup * add ref test * use correct test * remove iconButton changes * hellllllo * fix build error * transition styles * wip, transitiob broken * constants * update README * wip, translate grid, still not working * build error and export const * move handle click to context * unique test ids for toolbarIconButton * move test harnesses to testing dir * aria label check * update README * toolbar layout, wip * standalone overlay not working * add back inner drawer styles * scrolling and shadows * remove some comments and shouldAnimate * clean up embeddedDrawerLayout * comments * overlayDrawerLayout cleanup * constants for grid areas * shadow transition * rename removeShadowStyles * remove some comments * remove some styles * move to DrawerToolbarLayout * update stories * controls to exclude * update stories * Add more descriptive labels to some toolbar icons * clean up * tsdocs for LayoutData * fix grid columns on mobile and remove overflow from story * update stories * wip, position absolute standalone drawer animtion * wip: adjust keyframe timing in drawer animation for smoother transition * feat: enhance drawer styles with border adjustments and animation fixes * add opacity to inner container, add shouldAnimate check * added some clarifying comments about styles * fix tests and run lint * refactor: improve transition properties and ensure consistent animation behavior for drawer components * refactor: rename type for clarity and remove unused styles file * update README * add temp height to cloudnav story * remove comment and pass args in stories * update stories so arg does not override displayMode * add comment about story border * remove height transition * sandy feedback, semibold drawer title * refactor: update height properties to use 100% for consistency across drawer layouts * remove comment * add back visibility hidden and focus close button * add a comment about the shadow padding * add exports * refactor: reorganize imports and export constants * lint * remove redundant padding from drawer styles * remove green border from story * update constants * fix build error * specify embedded transitions, combine embedded and overlay types * refactor(drawer): consolidate drawer layout components * refactor(drawer): remove deprecated DrawerTabs component and related files * remove DrawerContext * remove comment in drawer stack * fix(drawer): update default drawer index * refactor(drawer): enhance exports and update warning message for DrawerLayout * refactor(drawer): update README and types for clarity on display modes and remove initial open state * refactor(drawer): reorder exports
* add toolbar * add keyboard focus management * fix focus hijacking * naming * updates types, fixes focus on click * Toolbar focus state * fix error * add stories * toolbar generated stories * ToolbarIconButton generated stories * update comments * add testids and add an error if trying to use ToolbarIconButton outside of Toolbar * interaction tests * WIP test harnesses * test harnesses * toolbar specs * ToolbarIconButton specs * lint * pass className to styles * README * add missing deps * use test utils in interaction tests * changesets * remove darkMode from context * fix ts error * some cleanup * add ref test * use correct test * remove iconButton changes * hellllllo * fix build error * transition styles * wip, transitiob broken * constants * update README * wip, translate grid, still not working * build error and export const * move handle click to context * unique test ids for toolbarIconButton * move test harnesses to testing dir * aria label check * update README * toolbar layout, wip * standalone overlay not working * add back inner drawer styles * scrolling and shadows * remove some comments and shouldAnimate * clean up embeddedDrawerLayout * comments * overlayDrawerLayout cleanup * constants for grid areas * shadow transition * rename removeShadowStyles * remove some comments * remove some styles * move to DrawerToolbarLayout * update stories * controls to exclude * update stories * Add more descriptive labels to some toolbar icons * provider with tests * add imports * refactor DrawerToolbarLayout to use context * update DrawerToolbarLayout so content and title are optional * wip, test ids for testing * update test harnesses * update label in story * clean up * tsdocs for LayoutData * fix grid columns on mobile and remove overflow from story * fix grid columns on mobile and remove overflow from story * update stories * add back plus * update long content * update layout stories and add interaction tests * interaction to Interaction story name * wip, position absolute standalone drawer animtion * wip: adjust keyframe timing in drawer animation for smoother transition * feat: enhance drawer styles with border adjustments and animation fixes * Enhance drawer animations and state management * add opacity to inner container, add shouldAnimate check * added some clarifying comments about styles * fix tests and run lint * refactor: improve transition properties and ensure consistent animation behavior for drawer components * refactor: rename type for clarity and remove unused styles file * update drawer toolbar context tsdoc, lint * refactor: update import paths and enhance drawer toolbar context tests * refactor: streamline import statements and add pauses for visibility in interaction stories * update README * add DrawerToolbarLayout to README * update README * add temp height to cloudnav story * remove comment and pass args in stories * update stories so arg does not override displayMode * add comment about story border * remove height transition * pass rest in story * sandy feedback, semibold drawer title * add onClose to README, add exports, fix eslint warnings * add note on height to README * add note on data and toolbar items in README * some more README updates * refactor: update height properties to use 100% for consistency across drawer layouts * remove comment * replace shouldCloseDrawer with isDrawerOpen, replace getActiveDrawerContent with activeDrawerContent * forgot to save file * refactor: rename variable getActiveDrawerContent to activeDrawerContent * add back visibility hidden and focus close button * add a comment about the shadow padding * add exports * refactor: reorganize imports and export constants * lint * remove redundant padding from drawer styles * remove green border from story * update constants * fix build error * specify embedded transitions, combine embedded and overlay types * refactor(drawer): consolidate drawer layout components * refactor(drawer): remove deprecated DrawerTabs component and related files * remove DrawerContext * remove comment in drawer stack * fix(drawer): update default drawer index * refactor(drawer): enhance exports and update warning message for DrawerLayout * refactor(drawer): update README and types for clarity on display modes and remove initial open state * refactor(drawer): reorder exports * run lint * fix failing ui tests and merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.