CDRIVER-4136 Drop debug-compile-c89 task (#962)

Author: kevinAlbs

.evergreen/config.yml

@@ -1043,24 +1043,6 @@ tasks:
         export DEBUG="ON"
         CC='${CC}' MARCH='${MARCH}' sh .evergreen/compile.sh
   - func: upload build
-- name: debug-compile-c89
-  tags:
-  - c89
-  - debug-compile
-  - special
-  - stdflags
-  commands:
-  - command: shell.exec
-    type: test
-    params:
-      working_dir: mongoc
-      shell: bash
-      script: |-
-        set -o errexit
-        export CFLAGS="-std=c89 -pedantic"
-        export DEBUG="ON"
-        CC='${CC}' MARCH='${MARCH}' sh .evergreen/compile.sh
-  - func: upload build
 - name: debug-compile-valgrind
   tags:
   - debug-compile
@@ -21546,7 +21528,7 @@ buildvariants:
   tasks:
   - release-compile
   - debug-compile-nosasl-nossl
-  - .debug-compile .stdflags !.c89
+  - .debug-compile .stdflags
   - .debug-compile !.sspi .openssl
   - .debug-compile !.sspi .nossl
   - .authentication-tests .openssl
@@ -21559,7 +21541,7 @@ buildvariants:
   tasks:
   - release-compile
   - debug-compile-nosasl-nossl
-  - .debug-compile .stdflags !.c89
+  - .debug-compile .stdflags
   - .debug-compile !.sspi .openssl
   - .debug-compile !.sspi .openssl-static
   - .debug-compile !.sspi .nossl
@@ -21590,7 +21572,7 @@ buildvariants:
   tasks:
   - release-compile
   - debug-compile-nosasl-nossl
-  - .debug-compile .stdflags !.c89
+  - .debug-compile .stdflags
   - .debug-compile !.sspi .openssl
   - .debug-compile !.sspi .nossl
   - .authentication-tests .openssl
@@ -21607,7 +21589,7 @@ buildvariants:
   - release-compile
   - debug-compile-nosasl-nossl
   - debug-compile-no-align
-  - .debug-compile .stdflags !.c89
+  - .debug-compile .stdflags
   - .debug-compile !.sspi .nossl .nosasl
   - .latest .nossl .nosasl
   - .5.0 .nossl .nosasl
@@ -21625,7 +21607,7 @@ buildvariants:
   - release-compile
   - debug-compile-nosasl-nossl
   - debug-compile-no-align
-  - .debug-compile .stdflags !.c89
+  - .debug-compile .stdflags
   - .debug-compile !.sspi .nossl .nosasl
   - .3.6 .nossl .nosasl
 - name: clang38ubuntu
@@ -21641,7 +21623,7 @@ buildvariants:
   - release-compile
   - debug-compile-nosasl-nossl
   - debug-compile-no-align
-  - .debug-compile .stdflags !.c89
+  - .debug-compile .stdflags
   - .debug-compile !.sspi .openssl
   - .debug-compile !.sspi .nossl
   - .authentication-tests .openssl

build/evergreen_config_lib/tasks.py

@@ -194,9 +194,6 @@ def __init__(self, task_name, suffix_commands, orchestration=True, **kwargs):
     SpecialTask('debug-compile-c99',
                 tags=['debug-compile', 'c99', 'stdflags'],
                 CFLAGS='-std=c99'),
-    SpecialTask('debug-compile-c89',
-                tags=['debug-compile', 'c89', 'stdflags'],
-                CFLAGS='-std=c89 -pedantic'),
     SpecialTask('debug-compile-valgrind',
                 tags=['debug-compile', 'valgrind'],
                 SASL='OFF',

build/evergreen_config_lib/variants.py

@@ -100,7 +100,7 @@ def days(n):
             'debian81-test',
             ['release-compile',
              'debug-compile-nosasl-nossl',
-             '.debug-compile .stdflags !.c89',
+             '.debug-compile .stdflags',
              '.debug-compile !.sspi .openssl',
              '.debug-compile !.sspi .nossl',
              '.authentication-tests .openssl',
@@ -111,7 +111,7 @@ def days(n):
             'debian92-test',
             ['release-compile',
              'debug-compile-nosasl-nossl',
-             '.debug-compile .stdflags !.c89',
+             '.debug-compile .stdflags',
              '.debug-compile !.sspi .openssl',
              '.debug-compile !.sspi .openssl-static',
              '.debug-compile !.sspi .nossl',
@@ -139,7 +139,7 @@ def days(n):
             'archlinux-test',
             ['release-compile',
              'debug-compile-nosasl-nossl',
-             '.debug-compile .stdflags !.c89',
+             '.debug-compile .stdflags',
              '.debug-compile !.sspi .openssl',
              '.debug-compile !.sspi .nossl',
              '.authentication-tests .openssl',
@@ -153,7 +153,7 @@ def days(n):
              'release-compile',
              'debug-compile-nosasl-nossl',
              'debug-compile-no-align',
-             '.debug-compile .stdflags !.c89',
+             '.debug-compile .stdflags',
              '.debug-compile !.sspi .nossl .nosasl',
              '.latest .nossl .nosasl',
              '.5.0 .nossl .nosasl',
@@ -168,7 +168,7 @@ def days(n):
              'release-compile',
              'debug-compile-nosasl-nossl',
              'debug-compile-no-align',
-             '.debug-compile .stdflags !.c89',
+             '.debug-compile .stdflags',
              '.debug-compile !.sspi .nossl .nosasl',
              '.3.6 .nossl .nosasl'],
             {'CC': 'clang', 'MARCH': 'i686'}),
@@ -182,7 +182,7 @@ def days(n):
              'release-compile',
              'debug-compile-nosasl-nossl',
              'debug-compile-no-align',
-             '.debug-compile .stdflags !.c89',
+             '.debug-compile .stdflags',
              '.debug-compile !.sspi .openssl',
              '.debug-compile !.sspi .nossl',
              '.authentication-tests .openssl',