CDRIVER-4136 drop debug-compile-c89 task #962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
changed the title
vector-of-bool
approved these changes
Apr 6, 2022
eramongodb
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Background & Motivation
The debug-compile-c89 task builds with
-std=c89 -pedantic.Removing the debug-compile-c89 task will help to enable copying mlib into mongo-c-driver.
libmongoc already uses several c99 features, noted in the comments of CDRIVER-4136.
Risks
This may impact consumers building with
-std=c89or building with a compiler not tested on Evergreen. We may add more non-C89 code that break consumers. I think it is low risk.