CDRIVER-4499 Set bson_error when hello response is malformed #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Oct 20, 2022
alcaeus
reviewed
Oct 20, 2022
kevinAlbs
approved these changes
Oct 20, 2022
kevinAlbs
pushed a commit
that referenced
this pull request
Mar 27, 2023
CDRIVER-4499 add bson_set_error to invalid types in handle hello
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before when a type error occurred in
mongoc_server_description_handle_hellothe program jumped to thefailurelabel and exited without setting an error. Now thefailurelabel sets the error message and code as a type error. There are two different types of failures inmongoc_server_description_handle_hellowith different error codes, so thefailurelabel was split into two labels to make it clearer which type of error is occuring.